Re: [Qemu-trivial] [PATCH] error.c: don't return value for void function

[Paolo Bonzini]

Il 16/04/2012 09:32, Amos Kong ha scritto:
> It is invalid to return a value from a function
> returning void.
> 
> Signed-off-by: Amos Kong <address@hidden>
> ---
>  error.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/error.c b/error.c
> index d3455ab..a52b771 100644
> --- a/error.c
> +++ b/error.c
> @@ -93,7 +93,7 @@ QDict *error_get_data(Error *err)
>  void error_set_field(Error *err, const char *field, const char *value)
>  {
>      QDict *dict = qdict_get_qdict(err->obj, "data");
> -    return qdict_put(dict, field, qstring_from_str(value));
> +    qdict_put(dict, field, qstring_from_str(value));
>  }
>  
>  void error_free(Error *err)

Reviewed-by: Paolo Bonzini <address@hidden>