[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean up

From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes
Date: Thu, 22 Mar 2012 01:05:34 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1

Il 21/03/2012 22:02, Peter Portante ha scritto:
> Hi Folks,
> Please forgive me if you find these changes are annoying, as I am trying to
> learn the ropes of patch submission with git ahead of making a real patch.
> While working on the code, I found that scripts/checkpatch.pl will flag lines
> that I am changing as not adhereing to the codeing standard due to
> pre-existing coding violations. So I figured I could learn a bit about how to
> submit patches by fixing these files I will be touching before submitting the
> code changes.

I think slirp is a mess and it's not worth doing this kind of sweeping
change.  Just ignore checkpatch output for slirp.

For the others, the changes are pretty small so they could be doable.
If you want to change them then please also add braces around if statements.

In any case, your patch submission workflow seems to be fine. :P


reply via email to

[Prev in Thread] Current Thread [Next in Thread]