[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: Remove unused inlin
From: |
Andreas Färber |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: Remove unused inline function |
Date: |
Mon, 19 Mar 2012 11:33:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 |
Hello Stefan,
Am 17.03.2012 13:00, schrieb Stefan Weil:
> Function set_HILO is not needed anywhere.
Does this cause any warnings? Given the state mips is currently in (TCG
patches queuing), I'd suggest to hold this off for a bit, but I don't
really mind either way.
Commit message does not mention if this was never used in the first
place or became unused during TCG conversion or some other refactoring?
Andreas
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> target-mips/op_helper.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 3a20731..7b77d5a 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -193,12 +193,6 @@ static inline uint64_t get_HILO (void)
> return ((uint64_t)(env->active_tc.HI[0]) << 32) |
> (uint32_t)env->active_tc.LO[0];
> }
>
> -static inline void set_HILO (uint64_t HILO)
> -{
> - env->active_tc.LO[0] = (int32_t)HILO;
> - env->active_tc.HI[0] = (int32_t)(HILO >> 32);
> -}
> -
> static inline void set_HIT0_LO (target_ulong arg1, uint64_t HILO)
> {
> env->active_tc.LO[0] = (int32_t)(HILO & 0xFFFFFFFF);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-trivial] [PATCH] target-mips: Remove unused inline function, Stefan Hajnoczi, 2012/03/19