[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [RESEND PATCH] ioapic: fix build with DE

From: Jason Wang
Subject: Re: [Qemu-trivial] [Qemu-devel] [RESEND PATCH] ioapic: fix build with DEBUG_IOAPIC
Date: Mon, 19 Mar 2012 11:22:18 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

On 03/16/2012 06:32 PM, Andreas Färber wrote:
Am 16.03.2012 10:10, schrieb Jason Wang:
ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 
has type ‘uint64_t’

Signed-off-by: Jason Wang<address@hidden>
PRIx64 is indeed needed here. However, this drops the 08 without mention
in the commit message - was it intended?

Not intended, my fault, thanks for pointing this.

  hw/ioapic.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ioapic.c b/hw/ioapic.c
index 3fee011..1ff31a1 100644
--- a/hw/ioapic.c
+++ b/hw/ioapic.c
@@ -195,7 +195,7 @@ ioapic_mem_write(void *opaque, target_phys_addr_t addr, 
uint64_t val,
          if (size != 4) {
-        DPRINTF("write: %08x = %08x\n", s->ioregsel, val);
+        DPRINTF("write: %08x = %" PRIx64 "\n", s->ioregsel, val);
          switch (s->ioregsel) {
          case IOAPIC_REG_ID:
              s->id = (val>>  IOAPIC_ID_SHIFT)&  IOAPIC_ID_MASK;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]