[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] qemu-ga: for w32, fix leaked handle ov.hEvent in

From: Jeff Cody
Subject: [Qemu-trivial] [PATCH] qemu-ga: for w32, fix leaked handle ov.hEvent in ga_channel_write()
Date: Thu, 15 Mar 2012 14:26:18 -0400

In the function ga_channel_write(), the handle ov.hEvent is created
by the call to CreateEvent(). However, the handle is not closed
prior to the function return.

This patch closes the handle before the return of the function.

Kudos to Paolo Bonzini for spotting this bug.

Signed-off-by: Jeff Cody <address@hidden>
 qga/channel-win32.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/qga/channel-win32.c b/qga/channel-win32.c
index 190251b..16bf44a 100644
--- a/qga/channel-win32.c
+++ b/qga/channel-win32.c
@@ -259,6 +259,10 @@ static GIOStatus ga_channel_write(GAChannel *c, const char 
*buf, size_t size,
         *count = written;
+    if (ov.hEvent) {
+        CloseHandle(ov.hEvent);
+        ov.hEvent = NULL;
+    }
     return status;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]