[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] osdep: Remove local definition o

From: Andreas Färber
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof
Date: Mon, 05 Mar 2012 14:23:13 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2

Am 05.03.2012 07:22, schrieb Stefan Weil:
> The macro offsetof is defined in stddef.h. It is conforming to
> the standards C89, C99 and POSIX.1-2001 (see man page), so it
> is a sufficiently old standard.
> Therefore chances are very high that QEMU never needs a local
> definition of this macro.
> osdep.h already includes stddef.h, so this patch simply removes
> the unneeded code from the files configure and osdep.h.
> If we ever need the local definition again, it should be added
> to compiler.h (the macro is usually provided with the compiler,
> it is not OS specific).
> Signed-off-by: Stefan Weil <address@hidden>

Did you check when this was introduced and whether the commit message
gave any explanation why?


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]