[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-barrier: Fix build failure
From: |
Andreas Färber |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC Mac OS X |
Date: |
Tue, 01 Nov 2011 19:39:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 |
Am 01.11.2011 10:39, schrieb Eric Sunshine:
> qemu-barrier.h tests if macro __powerpc__ is defined, however, the
> preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
> __powerpc__.
> Resolve by testing instead for qemu-provided _ARCH_PPC.
This part is actually wrong: _ARCH_PPC is compiler-provided.
>
> Signed-off-by: Eric Sunshine <address@hidden>
I currently don't have access to my ppc64 box, so
Reviewed-by: Andreas Färber <address@hidden>
Next time please cc malc (TCG ppc) and me (Darwin) on this.
Thanks,
Andreas
> ---
>
> The anomalous __powerpc__ test appears only in qemu-barrier.h.
> No other source files reference this name.
>
> Cc: David Gibson <address@hidden>
>
> qemu-barrier.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-barrier.h b/qemu-barrier.h
> index 735eea6..c11bb2b 100644
> --- a/qemu-barrier.h
> +++ b/qemu-barrier.h
> @@ -14,7 +14,7 @@
> */
> #define smp_wmb() barrier()
>
> -#elif defined(__powerpc__)
> +#elif defined(_ARCH_PPC)
>
> /*
> * We use an eieio() for a wmb() on powerpc. This assumes we don't