[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] Patch for ui/cocoa.m
From: |
Andreas Färber |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] Patch for ui/cocoa.m |
Date: |
Tue, 18 Oct 2011 11:11:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110922 Thunderbird/7.0 |
Hello Juan,
Am 18.10.2011 03:22, schrieb Juan Pineda:
> This is my first time submitting a patch, so please let me know if I'm not
> following the correct protocol.
Please see http://wiki.qemu.org/Contribute/SubmitAPatch
Using the git-send-mail tool assures that the patch format gets right.
Then, this patch despite its small size is not "trivial" so instead of
address@hidden please cc address@hidden for Cocoa. Thanks.
> Under OSX Lion the boot volume dialog is not closed and it permanently
> obscures the emulator window since under Lion the dialog cannot be
> repositioned. The fix adds only to add a single line to close the dialog.
I don't have access to v10.7 so please describe the problem in more
details: What command line do you use? If using the right arguments you
shouldn't see a window at all. Are you maybe using -drive instead of
-hda and that is not yet handled correctly?
Apart from this issue, is it working correctly for you?
Regards,
Andreas
> Signed-off-by: Juan Pineda <address@hidden>
>
> Thanks!
> -Juan
>
>
>> git diff ui/cocoa.m
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index d9e4e3d..4b42462 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -811,6 +811,8 @@ QemuCocoaView *cocoaView;
>
> char **argv = (char**)malloc( sizeof(char*)*3 );
>
> + [sheet close];
> +
> asprintf(&argv[0], "%s", bin);
> asprintf(&argv[1], "-hda");
> asprintf(&argv[2], "%s", img);
>
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg