Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include

[Alexander Graf]

On 04.07.2011, at 23:02, Peter Maydell wrote:

> Remove the include of setjmp.h from the cpu.h of target-alpha
> and target-ppc. This is unnecessary because cpu-defs.h already
> includes this header; this change brings these two targets
> into line with all the rest.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Yeah, I actually think no code (unless specifically configure'd for it) should 
include non-local headers (<...> instead of "..."). Of course that would 
include device/target specific headers as well ;).


Acked-by: Alexander Graf <address@hidden>

> ---
> target-alpha/cpu.h |    2 --
> target-ppc/cpu.h   |    2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
> index 411bd55..78caa79 100644
> --- a/target-alpha/cpu.h
> +++ b/target-alpha/cpu.h
> @@ -28,8 +28,6 @@
> 
> #include "cpu-defs.h"
> 
> -#include <setjmp.h>
> -
> #include "softfloat.h"
> 
> #define TARGET_HAS_ICE 1
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 84f8ff6..d903366 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -75,8 +75,6 @@
> 
> #include "cpu-defs.h"
> 
> -#include <setjmp.h>
> -
> #include "softfloat.h"
> 
> #define TARGET_HAS_ICE 1
> -- 
> 1.7.4.1
> 
>