[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] Fwd: [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset

From: Jordan Justen
Subject: [Qemu-trivial] Fwd: [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode
Date: Fri, 8 Apr 2011 18:47:17 -0700

Is this a 'trivial patch,' or does hw/pflash_cfi02 have an active maintainer?



---------- Forwarded message ----------
From: Jordan Justen <address@hidden>
Date: Sun, Apr 3, 2011 at 13:16
Subject: [Qemu-devel] [PATCH] hw/pflash_cfi02: Fix lazy reset of ROMD mode
To: address@hidden
Cc: Jordan Justen <address@hidden>

When checking pfl->rom_mode for when to lazily reenter ROMD mode,
the value was check was the opposite of what it should have been.
This prevent the part from returning to ROMD mode after a write
was made to the CFI rom region.

Signed-off-by: Jordan Justen <address@hidden>
 hw/pflash_cfi02.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/pflash_cfi02.c b/hw/pflash_cfi02.c
index 30c8aa4..370c5ee 100644
--- a/hw/pflash_cfi02.c
+++ b/hw/pflash_cfi02.c
@@ -112,7 +112,7 @@ static uint32_t pflash_read (pflash_t *pfl,
target_phys_addr_t offset,

    DPRINTF("%s: offset " TARGET_FMT_plx "\n", __func__, offset);
    ret = -1;
-    if (pfl->rom_mode) {
+    if (!pfl->rom_mode) {
        /* Lazy reset of to ROMD mode */
        if (pfl->wcycle == 0)
            pflash_register_memory(pfl, 1);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]