Re: [PATCH 1/2] meson: define qemu_isa_flags

[Paolo Bonzini]

On Mon, Oct 7, 2024 at 4:46 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
> > -  qemu_common_flags = ['-march=i486'] + qemu_common_flags
> > +  qemu_isa_flags = ['-march=i486']
>
> Use += ?

Here the qemu_isa_flags are known to be empty.

> > -      qemu_common_flags = ['-mcx16'] + qemu_common_flags
> > +      qemu_isa_flags = ['-mcx16'] + qemu_isa_flags
>
> Likewise, why verbosely prepend, rather than append with += ?
> The same for all others, including
>
> > +qemu_common_flags = qemu_isa_flags + qemu_common_flags

The prepending behavior came from CPU_CFLAGS originally being before
all other compiler flags.

I just didn't want to change behavior here (especially since this
patch was already about subtle changes in behavior). But you're right
that at least within qemu_isa_flags the order should not matter.

Paolo