Re: [PATCH v4] s390: kvm: adjust diag318 resets to retain data

[Thomas Huth]

On 23/11/2021 10.28, Christian Borntraeger wrote:
> Am 17.11.21 um 16:23 schrieb Collin Walling:
> > The CPNC portion of the diag318 data is erroneously reset during an
> > initial CPU reset caused by SIGP. Let's go ahead and relocate the
> > diag318_info field within the CPUS390XState struct such that it is
> > only zeroed during a clear reset. This way, the CPNC will be retained
> > for each VCPU in the configuration after the diag318 instruction
> > has been invoked.
> >
> > The s390_machine_reset code already takes care of zeroing the diag318
> > data on VM resets, which also cover resets caused by diag308.
> >
> > Signed-off-by: Collin Walling <walling@linux.ibm.com>
> > Fixes: fabdada9357b ("s390: guest support for diagnose 0x318")
> > Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> > Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
>
> Thomas, I think this is good to go. Will you take it via your tree?

Yes, queued to s390x-next now:

https://gitlab.com/thuth/qemu/-/commits/s390x-next/

 Thomas