[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 17/19] tcg: save vaddr temp for plugin usage
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [PATCH v2 17/19] tcg: save vaddr temp for plugin usage |
|
Date: |
Sat, 22 Feb 2020 22:06:56 -0500 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Feb 13, 2020 at 22:51:07 +0000, Alex Bennée wrote:
> From: Richard Henderson <address@hidden>
>
> While do_gen_mem_cb does copy (via extu_tl_i64) vaddr into a new temp
> this won't help if the vaddr temp gets clobbered by the actual
> load/store op. To avoid this clobbering we explicitly copy vaddr
> before the op to ensure it is live my the time we do the
> instrumentation.
s/my the time/by the time/
Reviewed-by: Emilio G. Cota <address@hidden>
E.