Re: [PATCH 0/2] qemu-img: Fix convert -n -B for backing-less targets

[John Snow]

On 1/21/20 10:59 AM, Max Reitz wrote:
> Hi,
> 
> When reviewing David’s series to add --target-is-zero convert, I looked
> for a case to show that the current implementation will crash if
> -n --target-is-zero is used together with -B.  It then turned out that
> -B will always crash when combined with -n and the target image does not
> have a backing file set in its image header.
> 
> This series fixes that.
> 
> 
> Max Reitz (2):
>   qemu-img: Fix convert -n -B for backing-less targets
>   iotests: Test convert -n -B to backing-less target
> 
>  qemu-img.c                 |  2 +-
>  tests/qemu-iotests/122     | 14 ++++++++++++++
>  tests/qemu-iotests/122.out |  5 +++++
>  3 files changed, 20 insertions(+), 1 deletion(-)
> 

Hello.
Makes sense to me.

Reviewed-by: John Snow <address@hidden>

(My brain had an awfully tumultuous 35 seconds comprehending that
"is_new" was not a synonym for "-n was provided", but actually means the
opposite.)