[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/13] Fixes for DP8393X SONIC device emulation
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 00/13] Fixes for DP8393X SONIC device emulation |
Date: |
Fri, 20 Dec 2019 11:16:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
Le 20/12/2019 à 05:17, Finn Thain a écrit :
> Hi All,
>
> There are bugs in the DP8393X emulation that can stop packet reception.
>
> Whilst debugging the device I found that the receiver algorithm differs
> from the one described in the National Semiconductor datasheet.
>
> These issues and others are addressed by this patch series.
>
> This series has only been tested with Linux/m68k guests. It needs further
> testing with MIPS Magnum guests such as NetBSD or Windows NT.
>
> Note that the mainline Linux sonic driver also has bugs.
> Those bugs have been fixed in a series of patches at,
> https://github.com/fthain/linux/commits/mac68k
>
> ---
> Changed since v1:
> - Minor revisions described in patch descriptions.
> - Dropped patches 4/10 and 7/10.
> - Added 5 new patches.
>
>
> Finn Thain (13):
> dp8393x: Mask EOL bit from descriptor addresses
> dp8393x: Clean up endianness hacks
> dp8393x: Have dp8393x_receive() return the packet size
> dp8393x: Update LLFA and CRDA registers from rx descriptor
> dp8393x: Clear RRRA command register bit only when appropriate
> dp8393x: Implement packet size limit and RBAE interrupt
> dp8393x: Don't stop reception upon RBE interrupt assertion
> dp8393x: Don't clobber packet checksum
> dp8393x: Use long-word-aligned RRA pointers in 32-bit mode
> dp8393x: Pad frames to word or long word boundary
> dp8393x: Clear descriptor in_use field when necessary
> dp8393x: Always update RRA pointers and sequence numbers
> dp8393x: Correctly advance RRP
>
> hw/net/dp8393x.c | 147 ++++++++++++++++++++++++++++++++---------------
> 1 file changed, 100 insertions(+), 47 deletions(-)
>
For q800:
Tested-by: Laurent Vivier <address@hidden>
- [PATCH v2 10/13] dp8393x: Pad frames to word or long word boundary, (continued)
- [PATCH v2 10/13] dp8393x: Pad frames to word or long word boundary, Finn Thain, 2019/12/19
- [PATCH v2 02/13] dp8393x: Clean up endianness hacks, Finn Thain, 2019/12/19
- [PATCH v2 08/13] dp8393x: Don't clobber packet checksum, Finn Thain, 2019/12/19
- [PATCH v2 06/13] dp8393x: Implement packet size limit and RBAE interrupt, Finn Thain, 2019/12/19
- [PATCH v2 07/13] dp8393x: Don't stop reception upon RBE interrupt assertion, Finn Thain, 2019/12/19
- [PATCH v2 12/13] dp8393x: Always update RRA pointers and sequence numbers, Finn Thain, 2019/12/19
- [PATCH v2 11/13] dp8393x: Clear descriptor in_use field when necessary, Finn Thain, 2019/12/19
- [PATCH v2 13/13] dp8393x: Correctly advance RRP, Finn Thain, 2019/12/19
- [PATCH v2 01/13] dp8393x: Mask EOL bit from descriptor addresses, Finn Thain, 2019/12/19
- Re: [PATCH v2 00/13] Fixes for DP8393X SONIC device emulation,
Laurent Vivier <=