[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] qcow2: Fix image corruption bug in 4.1
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 0/2] qcow2: Fix image corruption bug in 4.1 |
Date: |
Fri, 25 Oct 2019 12:44:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 24.10.19 16:26, Kevin Wolf wrote:
> This series fixes an image corruption bug that was introduced in commit
> 69f47505e ('block: avoid recursive block_status call if possible'),
> first contained in the QEMU 4.1.0 release.
>
> This bug was reported by Michael Weiser on Launchpad:
> https://bugs.launchpad.net/qemu/+bug/1846427
>
> v2:
>
> - Dropped the assertion in qcow2_cache_do_get() for now. Making sure
> that it actually holds true for all callers requires more work and
> getting the corruption fix in quickly is important.
>
> - Use atomic_read() and add comment to qemu_co_mutex_assert_locked()
> implementation [Denis]
>
> Kevin Wolf (2):
> coroutine: Add qemu_co_mutex_assert_locked()
> qcow2: Fix corruption bug in qcow2_detect_metadata_preallocation()
>
> include/qemu/coroutine.h | 15 +++++++++++++++
> block/qcow2-refcount.c | 2 ++
> block/qcow2.c | 3 ++-
> 3 files changed, 19 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature