[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH 1/2] nbd/client: fix nbd_negotiate_simple_meta_
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-stable] [PATCH 1/2] nbd/client: fix nbd_negotiate_simple_meta_context |
|
Date: |
Fri, 27 Apr 2018 10:20:11 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/27/2018 09:20 AM, Vladimir Sementsov-Ogievskiy wrote:
> Initialize received variable. Otherwise, is is possible for server to
> answer without any contexts, but we will set context_id to something
> random (received_id is not initialized too) and return 1, which is
> wrong.
>
> To solve it, just initialize received to false. Initialize received_id
> too, just to make all possible checkers happy.
>
> But was introduced in 78a33ab58782efdb206de14 "nbd: BLOCK_STATUS for
s/But/Bug/
> standard get_block_status function: client part" with the whole
> function.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature