Re: [Qemu-stable] [PATCH] block/mirror: honor ratelimit again

[Kevin Wolf]

Am 24.04.2018 um 14:35 hat Stefan Hajnoczi geschrieben:
> Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 ("block/mirror: change
> the semantic of 'force' of block-job-cancel") accidentally removed the
> ratelimit in the mirror job.
> 
> Reintroduce the ratelimit but keep the block-job-cancel force=true
> behavior that was added in commit
> b76e4458b1eb3c32e9824fe6aa51f67d2b251748.
> 
> Note that block_job_sleep_ns() returns immediately when the job is
> cancelled.  Therefore it's safe to unconditionally call
> block_job_sleep_ns() - a cancelled job does not sleep.
> 
> This commit fixes the non-deterministic qemu-iotests 185 output.  The
> test relies on the ratelimit to make the job sleep until the 'quit'
> command is processed.  Previously the job could complete before the
> 'quit' command was received since there was no ratelimit.
> 
> Cc: Liang Li <address@hidden>
> Cc: Jeff Cody <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Cc: address@hidden
Reviewed-by: Kevin Wolf <address@hidden>