[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_disc
From: |
Eric Blake |
Subject: |
Re: [Qemu-stable] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_discard |
Date: |
Fri, 22 May 2015 14:22:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/21/2015 09:40 PM, Fam Zheng wrote:
> Unsetting dirty globally with discard is not very correct. The discard may
> zero
> out sectors (depending on can_write_zeroes_with_unmap), we should replicate
> this change to destinition side to make sure that the guest sees the same
> data.
s/destinition/destination/
>
> Calling bdrv_reset_dirty also troubles mirror job because the hbitmap iterator
> doesn't expect unsetting of bits after current position.
>
> So let's do it the opposite way which fixes both problems: set the dirty bits
> if we are to discard it.
>
> Reported-by: address@hidden
> Signed-off-by: Fam Zheng <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> ---
> block/io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-stable] [PATCH v4 1/8] block: Add "base" option to bdrv_get_block_status, (continued)
- [Qemu-stable] [PATCH v4 2/8] qmp: Add optional bool "unmap" to drive-mirror, Fam Zheng, 2015/05/21
- [Qemu-stable] [PATCH v4 3/8] mirror: Do zero write on target if sectors not allocated, Fam Zheng, 2015/05/21
- [Qemu-stable] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_discard, Fam Zheng, 2015/05/21
- Re: [Qemu-stable] [PATCH v4 4/8] block: Fix dirty bitmap in bdrv_co_discard,
Eric Blake <=
- [Qemu-stable] [PATCH v4 5/8] block: Remove bdrv_reset_dirty, Fam Zheng, 2015/05/21
- [Qemu-stable] [PATCH v4 6/8] qemu-iotests: Make block job methods common, Fam Zheng, 2015/05/21
- [Qemu-stable] [PATCH v4 7/8] qemu-iotests: Add test case for mirror with unmap, Fam Zheng, 2015/05/21
- [Qemu-stable] [PATCH v4 8/8] iotests: Use event_wait in wait_ready, Fam Zheng, 2015/05/21