[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] musicpal: Fix flash mapping
From: |
Peter Maydell |
Subject: |
Re: [Qemu-stable] [PATCH] musicpal: Fix flash mapping |
Date: |
Fri, 7 Sep 2012 15:41:54 +0100 |
On 7 September 2012 00:03, Jan Kiszka <address@hidden> wrote:
> The old arithmetic assumed 32 physical address bits which is no longer
> true for ARM since 3cc0cd61f4.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> hw/musicpal.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index ad725b5..10c2c16 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1583,7 +1583,7 @@ static void musicpal_init(ram_addr_t ram_size,
> * image is smaller than 32 MB.
> */
> #ifdef TARGET_WORDS_BIGENDIAN
> - pflash_cfi02_register(0-MP_FLASH_SIZE_MAX, NULL,
> + pflash_cfi02_register(0x100000000-MP_FLASH_SIZE_MAX, NULL,
I don't think this will compile on a 32 bit system, will it?
You probably want an ULL suffix.
-- PMM
- [Qemu-stable] [PATCH] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/06
- Re: [Qemu-stable] [PATCH] musicpal: Fix flash mapping,
Peter Maydell <=
- Re: [Qemu-stable] [PATCH] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/07
- Re: [Qemu-stable] [PATCH] musicpal: Fix flash mapping, Peter Maydell, 2012/09/07
- Re: [Qemu-stable] [Qemu-devel] [PATCH] musicpal: Fix flash mapping, Blue Swirl, 2012/09/08
- Re: [Qemu-stable] [Qemu-devel] [PATCH] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- [Qemu-stable] [PATCH v2] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- Re: [Qemu-stable] [PATCH v2] musicpal: Fix flash mapping, Peter Maydell, 2012/09/08
- Re: [Qemu-stable] [PATCH v2] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- [Qemu-stable] [PATCH v2a] musicpal: Fix flash mapping, Jan Kiszka, 2012/09/08
- Re: [Qemu-stable] [PATCH v2a] musicpal: Fix flash mapping, Blue Swirl, 2012/09/08