|
From: | Jared Rossi |
Subject: | Re: [PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img |
Date: | Fri, 28 Jun 2024 14:01:12 -0400 |
User-agent: | Mozilla Thunderbird |
On 6/24/24 1:55 AM, Thomas Huth wrote:
[...]I think it should be fine, both functions are basically just a wrapper around the write() function in sclp.c, with sclp_print() being rather dumb while printf() is doing the usual string formatting before writing it out. I think in the long run, it would be nice to get rid of sclp_print() and replace it by puts() or printf() in the whole code, but doing that right now would likely cause quite some conflicts for Jared with his patch series, so I'd rather postpone that to a later point in time.
Hi Thomas,Converting the panics to returns will require me to modify/move some of the sclp_print() calls. Shall I go ahead and change them to printf() and puts() while I'm at it, or would you rather preserve the sclp_print() for now and then have a dedicated patch for the all replacements later? I'm not sure if we want to try to maintain some amount of consistency until we do a total conversion, or if you are OK with a mix of sclp_print() and printf() throughout in the meantime.
Regards, Jared Rossi
[Prev in Thread] | Current Thread | [Next in Thread] |