Re: [PATCH v2 0/2] target/s390x: Fix tracing header path in TCG mem_helper.c

[Paolo Bonzini]

On 6/13/24 12:44, Philippe Mathieu-Daudé wrote:
> In order to keep trace event headers local to their
> directory, introduce s390_skeys_get/s390_skeys_set
> helpers, fixing:
>
>    In file included from ../../target/s390x/tcg/mem_helper.c:33:
>    ../../target/s390x/tcg/trace.h:1:10: fatal error: 
> 'trace/trace-target_s390x_tcg.h' file not found
>    #include "trace/trace-target_s390x_tcg.h"
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    1 error generated.
>    ninja: build stopped: subcommand failed.
>
> Philippe Mathieu-Daudé (2):
>    hw/s390x: Introduce s390_skeys_get|set() helpers
>    target/s390x: Use s390_skeys_get|set() helper

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

>   include/hw/s390x/storage-keys.h | 10 ++++++++++
>   hw/s390x/s390-skeys.c           | 27 +++++++++++++++++++++++++++
>   target/s390x/mmu_helper.c       | 11 ++---------
>   target/s390x/tcg/mem_helper.c   | 16 ++++------------
>   hw/s390x/trace-events           |  4 ++++
>   target/s390x/trace-events       |  4 ----
>   6 files changed, 47 insertions(+), 25 deletions(-)