[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 04/10] target/s390x: Use gen_psw_addr_disp in pc_to_link_info
From: |
Richard Henderson |
Subject: |
[PATCH v2 04/10] target/s390x: Use gen_psw_addr_disp in pc_to_link_info |
Date: |
Wed, 5 Jun 2024 14:57:33 -0700 |
This is slightly more complicated than a straight displacement
for 31 and 24-bit modes. Dont bother with a cant-happen assert.
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/translate.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 14162769a9..2d611da8af 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -174,17 +174,19 @@ static void gen_psw_addr_disp(DisasContext *s, TCGv_i64
dest, int64_t disp)
static void pc_to_link_info(TCGv_i64 out, DisasContext *s)
{
- uint64_t pc = s->pc_tmp;
+ TCGv_i64 tmp;
- if (s->base.tb->flags & FLAG_MASK_32) {
- if (s->base.tb->flags & FLAG_MASK_64) {
- tcg_gen_movi_i64(out, pc);
- return;
- }
- pc |= 0x80000000;
+ if (s->base.tb->flags & FLAG_MASK_64) {
+ gen_psw_addr_disp(s, out, s->ilen);
+ return;
}
- assert(!(s->base.tb->flags & FLAG_MASK_64));
- tcg_gen_deposit_i64(out, out, tcg_constant_i64(pc), 0, 32);
+
+ tmp = tcg_temp_new_i64();
+ gen_psw_addr_disp(s, tmp, s->ilen);
+ if (s->base.tb->flags & FLAG_MASK_32) {
+ tcg_gen_ori_i64(tmp, tmp, 0x80000000);
+ }
+ tcg_gen_deposit_i64(out, out, tmp, 0, 32);
}
static TCGv_i64 psw_addr;
--
2.34.1
- [PATCH v2 00/10] target/s390x: pc-relative translation, Richard Henderson, 2024/06/05
- [PATCH v2 01/10] target/s390x: Change help_goto_direct to work on displacements, Richard Henderson, 2024/06/05
- [PATCH v2 02/10] target/s390x: Introduce gen_psw_addr_disp, Richard Henderson, 2024/06/05
- [PATCH v2 03/10] target/s390x: Remove pc argument to pc_to_link_into, Richard Henderson, 2024/06/05
- [PATCH v2 04/10] target/s390x: Use gen_psw_addr_disp in pc_to_link_info,
Richard Henderson <=
- [PATCH v2 05/10] target/s390x: Use gen_psw_addr_disp in save_link_info, Richard Henderson, 2024/06/05
- [PATCH v2 06/10] target/s390x: Use deposit in save_link_info, Richard Henderson, 2024/06/05
- [PATCH v2 08/10] target/s390x: Use ilen instead in branches, Richard Henderson, 2024/06/05
- [PATCH v2 07/10] target/s390x: Use gen_psw_addr_disp in op_sam, Richard Henderson, 2024/06/05
- [PATCH v2 09/10] target/s390x: Assert masking of psw.addr in cpu_get_tb_cpu_state, Richard Henderson, 2024/06/05
- [PATCH v2 10/10] target/s390x: Enable CF_PCREL, Richard Henderson, 2024/06/05