Re: [PATCH] target/s390x/cpu_models: Use 'first_cpu' in s390_get_feat_block()

[David Hildenbrand]

On 30.10.23 10:31, Philippe Mathieu-Daudé wrote:
> We already have a global 'first_cpu' variable storing a pointer
> to the first CPU, no need to use a static one.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/s390x/cpu_models.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index 4dead48650..540d445023 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -196,11 +196,7 @@ uint32_t s390_get_ibc_val(void)
>   
>   void s390_get_feat_block(S390FeatType type, uint8_t *data)
>   {
> -    static S390CPU *cpu;
> -
> -    if (!cpu) {
> -        cpu = S390_CPU(qemu_get_cpu(0));
> -    }
> +    S390CPU *cpu = S390_CPU(first_cpu);
>   
>       if (!cpu || !cpu->model) {
>           return;

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Cheers,

David / dhildenb