qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/5] hw/remote/proxy: Remove dubious 'event_notifier-posix


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 1/5] hw/remote/proxy: Remove dubious 'event_notifier-posix.c' include
Date: Thu, 8 Jun 2023 15:32:44 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2

On 8/6/23 15:31, Philippe Mathieu-Daudé wrote:
event_notifier-posix.c is registered in meson's util_ss[] source
set, which is built as libqemuutil.a.p library. Both tools and
system emulation binaries are linked with qemuutil, so there is
no point in including this source file.

Introduced in commit bd36adb8df ("multi-process: create IOHUB
object to handle irq").

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
Note, --enable-multiprocess doesn't seem to be covered in CI.
---
  hw/remote/proxy.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
index 1c7786b52c..2052d721e5 100644
--- a/hw/remote/proxy.c
+++ b/hw/remote/proxy.c
@@ -22,7 +22,6 @@
  #include "qom/object.h"
  #include "qemu/event_notifier.h"
  #include "sysemu/kvm.h"
-#include "util/event_notifier-posix.c"

Err wrong branch base, please discard this patch which is already
in Paolo's queue.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]