[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] target/s390x: Implement Early Exception Recognition

From: David Hildenbrand
Subject: Re: [PATCH 1/2] target/s390x: Implement Early Exception Recognition
Date: Tue, 14 Mar 2023 17:54:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 14.03.23 12:00, Ilya Leoshkevich wrote:
Generate specification exception if a reserved bit is set in the PSW
mask or if the PSW address is out of bounds dictated by the addresing

Reported-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>

Unofficially known to be broken (and ignored) for a long time :D

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
  target/s390x/cpu.c             | 26 ++++++++++++++++++++++++++
  target/s390x/cpu.h             |  1 +
  target/s390x/tcg/excp_helper.c |  3 ++-
  3 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index b10a8541ff8..8e6e46aa3d8 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -41,6 +41,26 @@
  #define CR0_RESET       0xE0UL
  #define CR14_RESET      0xC2000000UL;
+static bool is_early_exception_recognized(uint64_t mask, uint64_t addr)

Nit: I'd call this is_early_exception_psw() or sth like that.


Reviewed-by: David Hildenbrand <david@redhat.com>


David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]