Re: [PATCH 01/70] target/arm: Use rmode >= 0 for need_rmode

[Philippe Mathieu-Daudé]

On 6/3/23 14:54, Philippe Mathieu-Daudé wrote:
> On 27/2/23 06:41, Richard Henderson wrote:
> > Initialize rmode to -1 instead of keeping two variables.
> > This is already used elsewhere in translate-a64.c.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/arm/translate-a64.c | 34 ++++++----------------------------
> >   1 file changed, 6 insertions(+), 28 deletions(-)
> >
> > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
> > index b1fa210d64..1c575de3e0 100644
> > --- a/target/arm/translate-a64.c
> > +++ b/target/arm/translate-a64.c
> > @@ -12133,7 +12133,6 @@ static void 
> > disas_simd_two_reg_misc(DisasContext *s, uint32_t insn)
> >       int rn = extract32(insn, 5, 5);
> >       int rd = extract32(insn, 0, 5);
> >       bool need_fpstatus = false;
> > -    bool need_rmode = false;
> >       int rmode = -1;
>
> Unrelated, but rmode could be an enum arm_fprounding.

Arf I just noticed ARMFPRounding in the next patches :)

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>