[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 03/30] migration: Split save_live_pending() into state_pending

From: Juan Quintela
Subject: Re: [PULL 03/30] migration: Split save_live_pending() into state_pending_*
Date: Thu, 09 Feb 2023 16:24:26 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Avihai Horon <avihaih@nvidia.com> wrote:
> On 07/02/2023 2:56, Juan Quintela wrote:
>> External email: Use caution opening links or attachments
>> We split the function into to:
>> - state_pending_estimate: We estimate the remaining state size without
>>    stopping the machine.
>> - state pending_exact: We calculate the exact amount of remaining
>>    state.
>> The only "device" that implements different functions for _estimate()
>> and _exact() is ram.
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> I only noticed it now while rebasing my series on top of yours.
> I think the exact and estimate callbacks got mixed up here: we call
> .state_pending_estimate() in qemu_savevm_state_pending_exact() and
> .state_pending_exact() in qemu_savevm_state_pending_estimate().
> Also need to switch the !se->ops->state_pending_exact/estimate checks.

Good catch.
Sent a patch to fix it.

Thanks a lot.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]