[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] util/qemu-config: Fix "query-command-line-options" to pro

From: Markus Armbruster
Subject: Re: [PATCH v2] util/qemu-config: Fix "query-command-line-options" to provide the right values
Date: Fri, 11 Nov 2022 15:53:05 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Thomas Huth <thuth@redhat.com> writes:

> The "query-command-line-options" command uses a hand-crafted list
> of options that should be returned for the "machine" parameter.
> This is pretty much out of sync with reality, for example settings
> like "kvm_shadow_mem" or "accel" are not parameters for the machine
> anymore. Also, there is no distinction between the targets here, so
> e.g. the s390x-specific values like "loadparm" in this list also
> show up with the other targets like x86_64.
> Let's fix this now by geting rid of the hand-crafted list and by
> querying the properties of the machine classes instead to assemble
> the list.

Do we know what uses this command, and how these users are
inconvenienced by the flaw you're fixing?

I'm asking because the command is pretty much out of sync with reality
by (mis-)design.

> Fixes: 0a7cf217d8 ("fix regression of qmp_query_command_line_options")

Hah: "We need to find a better fix for 2.4." 

> Signed-off-by: Thomas Huth <thuth@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]