[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/26] target/s390x: Use tcg_constant_* in translate_vx.c.inc

From: Richard Henderson
Subject: Re: [PATCH 04/26] target/s390x: Use tcg_constant_* in translate_vx.c.inc
Date: Fri, 4 Nov 2022 10:05:17 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2

On 11/3/22 22:04, Ilya Leoshkevich wrote:
On Wed, Oct 05, 2022 at 08:43:59PM -0700, Richard Henderson wrote:
In most cases, this is a simple local allocate and free
replaced by tcg_constant_*.  In three cases, a variable
temp was initialized with a constant value -- reorg to
localize the constant.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
  target/s390x/tcg/translate_vx.c.inc | 45 +++++++++++++----------------
  1 file changed, 20 insertions(+), 25 deletions(-)


@@ -1359,7 +1359,7 @@ static DisasJumpType op_va(DisasContext *s, DisasOps *o)
  static void gen_acc(TCGv_i64 d, TCGv_i64 a, TCGv_i64 b, uint8_t es)
      const uint8_t msb_bit_nr = NUM_VEC_ELEMENT_BITS(es) - 1;
-    TCGv_i64 msb_mask = tcg_const_i64(dup_const(es, 1ull << msb_bit_nr));
+    TCGv_i64 msb_mask = tcg_constant_i64(dup_const(es, 1ull << msb_bit_nr));
      TCGv_i64 t1 = tcg_temp_new_i64();
      TCGv_i64 t2 = tcg_temp_new_i64();
      TCGv_i64 t3 = tcg_temp_new_i64();

This also fixes a leak, right?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]