[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/14] dump: Rename write_elf_loads to write_elf_phdr_load
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH v3 02/14] dump: Rename write_elf_loads to write_elf_phdr_loads |
Date: |
Thu, 21 Jul 2022 18:26:24 +0400 |
On Thu, Jul 21, 2022 at 5:24 PM Janosch Frank <frankja@linux.ibm.com> wrote:
>
> Let's make it a bit clearer that we write the program headers of the
> PT_LOAD type.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> dump/dump.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dump/dump.c b/dump/dump.c
> index 4d9658ffa2..0ed7cf9c7b 100644
> --- a/dump/dump.c
> +++ b/dump/dump.c
> @@ -490,7 +490,7 @@ static void get_offset_range(hwaddr phys_addr,
> }
> }
>
> -static void write_elf_loads(DumpState *s, Error **errp)
> +static void write_elf_phdr_loads(DumpState *s, Error **errp)
> {
> ERRP_GUARD();
> hwaddr offset, filesz;
> @@ -573,8 +573,8 @@ static void dump_begin(DumpState *s, Error **errp)
> return;
> }
>
> - /* write all PT_LOAD to vmcore */
> - write_elf_loads(s, errp);
> + /* write all PT_LOADs to vmcore */
> + write_elf_phdr_loads(s, errp);
> if (*errp) {
> return;
> }
> --
> 2.34.1
>
- [PATCH v3 00/14] dump: Add arch section and s390x PV dump, Janosch Frank, 2022/07/21
- [PATCH v3 01/14] dump: Introduce GuestPhysBlock offset and length filter functions, Janosch Frank, 2022/07/21
- [PATCH v3 02/14] dump: Rename write_elf_loads to write_elf_phdr_loads, Janosch Frank, 2022/07/21
- Re: [PATCH v3 02/14] dump: Rename write_elf_loads to write_elf_phdr_loads,
Marc-André Lureau <=
- [PATCH v3 03/14] dump: Convert GuestPhysBlock iterators and use the filter functions, Janosch Frank, 2022/07/21
- [PATCH v3 04/14] dump: Allocate header, Janosch Frank, 2022/07/21
- [PATCH v3 05/14] dump: Split write of section headers and data and add a prepare step, Janosch Frank, 2022/07/21
- [PATCH v3 06/14] dump: Reorder struct DumpState, Janosch Frank, 2022/07/21