|
From: | Pierre Morel |
Subject: | Re: [PATCH v5 2/9] vfio: tolerate migration protocol v1 uapi renames |
Date: | Tue, 19 Apr 2022 17:44:41 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 4/12/22 18:07, Matthew Rosato wrote:
On 4/12/22 11:50 AM, Pierre Morel wrote:On 4/4/22 20:17, Matthew Rosato wrote:The v1 uapi is deprecated and will be replaced by v2 at some point; this patch just tolerates the renaming of uapi fields to reflect v1 / deprecated status. Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com> --- hw/vfio/common.c | 2 +- hw/vfio/migration.c | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-)I do not understand why you need this patch in this series. Shouldn't it be separate?This patch is included because of the patch 1 kernel header sync, which pulls in uapi headers from kernel version 5.18-rc1 + my unmerged kernel uapi changes.This patch is unnecessary without a header sync (and in fact would break QEMU compile), and is unrelated to the rest of the series -- but QEMU will not compile without it once you update linux uapi headers to 5.18-rc1 (or greater) due to the v1 uapi for vfio migration being deprecated [1]. This means that ANY series that does a linux header sync starting from here on will need something like this patch to go along with the header sync (or a series that replaces v1 usage with v2?).If this patch looks good it could be included whenever a header sync is next needed, doesn't necessarily have to be with this series.[1] https://www.spinics.net/lists/kernel/msg4288200.html
arrg, seems I will need it too then. Thanks, Pierre -- Pierre Morel IBM Lab Boeblingen
[Prev in Thread] | Current Thread | [Next in Thread] |