[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch s390x/tcg: Implement Miscellaneous-Instruction-Extensions Faci
From: |
David Hildenbrand |
Subject: |
Re: patch s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x |
Date: |
Tue, 15 Feb 2022 09:48:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 15.02.22 03:59, David Miller wrote:
> Thanks for the review.
>
> I made all of the changes requested and sent again.
>
> The popcnt patch is in it, the tests are removed.
> I will see about changing the instructions in a manner that won't
> require building w. -march=z15 and sending a patch again after
> finished up the next task.
Let me take a quick peek: target/s390x/gen-features.c
static uint16_t base_GEN15_GA1[] = {
S390_FEAT_MISC_INSTRUCTION_EXT3,
};
So you can keep the tests as is. We just have to bump QEMU to a z15.
I'll reply with more details to your new patch.
> Will have Vector-Enhancements Facility 2 patch later this week hopefully.
>
Cool! Thanks
--
Thanks,
David / dhildenb