Re: [RFC v6 06/13] target/s390x: start moving TCG-only code to tcg/

[Al Cho]

On Thu, 2021-07-01 at 12:51 +0200, Thomas Huth wrote:
> On 29/06/2021 16.19, Cho, Yu-Chen wrote:
> > move everything related to translate, as well as HELPER code in tcg/
> > 
> > mmu_helper.c stays put for now, as it contains both TCG and KVM code.
> > 
> > The internal.h file is renamed to s390x-internal.h, because of the
> > risk of collision with other files with the same name.
> 
> IMHO the renaming from internal.h to s390x-internal.h should be done in
> a 
> separate patch, since it's not directly related to the movement of the
> other 
> files.
> 

Indeed, this patch should not include this. The renaming from
internal.h to s390x-internal.h would be done in a separate patch.


> [...]
> > diff --git a/target/s390x/internal.h b/target/s390x/s390x-
> > internal.h
> > similarity index 98%
> > rename from target/s390x/internal.h
> > rename to target/s390x/s390x-internal.h
> > index 9256275376..17edd4d13b 100644
> > --- a/target/s390x/internal.h
> > +++ b/target/s390x/s390x-internal.h
> > @@ -240,6 +240,12 @@ uint32_t calc_cc(CPUS390XState *env, uint32_t
> > cc_op, uint64_t src, uint64_t dst,
> >   #ifndef CONFIG_USER_ONLY
> >   unsigned int s390_cpu_halt(S390CPU *cpu);
> >   void s390_cpu_unhalt(S390CPU *cpu);
> > +void s390_cpu_init_sysemu(Object *obj);
> > +bool s390_cpu_realize_sysemu(DeviceState *dev, Error **errp);
> > +void s390_cpu_finalize(Object *obj);
> > +void s390_cpu_class_init_sysemu(CPUClass *cc);
> > +void s390_cpu_machine_reset_cb(void *opaque);
> 
> This hunk rather belongs into the next patch instead.
> 

True, this part in 07 would be better, I will move this to 07.

Thanks, AL