[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 04/15] linux-user/s390x: Remove restore_sigregs return value
From: |
Richard Henderson |
Subject: |
[PATCH v2 04/15] linux-user/s390x: Remove restore_sigregs return value |
Date: |
Wed, 28 Apr 2021 12:33:57 -0700 |
The function cannot fail.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/s390x/signal.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c
index 1dfca71fa9..e455a9818d 100644
--- a/linux-user/s390x/signal.c
+++ b/linux-user/s390x/signal.c
@@ -230,10 +230,8 @@ give_sigsegv:
force_sigsegv(sig);
}
-static int
-restore_sigregs(CPUS390XState *env, target_sigregs *sc)
+static void restore_sigregs(CPUS390XState *env, target_sigregs *sc)
{
- int err = 0;
int i;
for (i = 0; i < 16; i++) {
@@ -251,8 +249,6 @@ restore_sigregs(CPUS390XState *env, target_sigregs *sc)
for (i = 0; i < 16; i++) {
__get_user(*get_freg(env, i), &sc->fpregs.fprs[i]);
}
-
- return err;
}
long do_sigreturn(CPUS390XState *env)
@@ -271,9 +267,7 @@ long do_sigreturn(CPUS390XState *env)
target_to_host_sigset_internal(&set, &target_set);
set_sigmask(&set); /* ~_BLOCKABLE? */
- if (restore_sigregs(env, &frame->sregs)) {
- goto badframe;
- }
+ restore_sigregs(env, &frame->sregs);
unlock_user_struct(frame, frame_addr, 0);
return -TARGET_QEMU_ESIGRETURN;
@@ -297,9 +291,7 @@ long do_rt_sigreturn(CPUS390XState *env)
set_sigmask(&set); /* ~_BLOCKABLE? */
- if (restore_sigregs(env, &frame->uc.tuc_mcontext)) {
- goto badframe;
- }
+ restore_sigregs(env, &frame->uc.tuc_mcontext);
target_restore_altstack(&frame->uc.tuc_stack, env);
--
2.25.1
- [PATCH v2 00/15] linux-user/s390x: some signal fixes, Richard Henderson, 2021/04/28
- [PATCH v2 02/15] linux-user/s390x: Use uint16_t for signal retcode, Richard Henderson, 2021/04/28
- [PATCH v2 01/15] linux-user/s390x: Fix sigframe types, Richard Henderson, 2021/04/28
- [PATCH v2 04/15] linux-user/s390x: Remove restore_sigregs return value,
Richard Henderson <=
- [PATCH v2 03/15] linux-user/s390x: Remove PSW_ADDR_AMODE, Richard Henderson, 2021/04/28
- [PATCH v2 06/15] linux-user/s390x: Fix sigcontext sregs value, Richard Henderson, 2021/04/28
- [PATCH v2 05/15] linux-user/s390x: Fix trace in restore_regs, Richard Henderson, 2021/04/28
- [PATCH v2 07/15] linux-user/s390x: Use tswap_sigset in setup_rt_frame, Richard Henderson, 2021/04/28
- [PATCH v2 08/15] linux-user/s390x: Tidy save_sigregs, Richard Henderson, 2021/04/28