Re: [PATCH v2 1/1] s390x: css: report errors from ccw_dstream_read/write

[Pierre Morel]

On 4/9/21 12:27 PM, Cornelia Huck wrote:
> On Thu,  8 Apr 2021 18:32:09 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
> > ccw_dstream_read/write functions returned values are sometime
> > not taking into account and reported back to the upper level
> > of interpretation of CCW instructions.
> >
> > It follows that accessing an invalid address does not trigger
> > a subchannel status program check to the guest as it should.
> >
> > Let's test the return values of ccw_dstream_write[_buf] and
> > ccw_dstream_read[_buf] and report it to the caller.
> >
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > ---
> >   hw/char/terminal3270.c | 11 +++++--
> >   hw/s390x/3270-ccw.c    |  5 +++-
> >   hw/s390x/css.c         | 14 +++++----
> >   hw/s390x/virtio-ccw.c  | 66 ++++++++++++++++++++++++++++++------------
> >   4 files changed, 69 insertions(+), 27 deletions(-)
>
> Thanks, queued to s390-fixes (with cc:stable added.)

Thanks,
Pierre

--
Pierre Morel
IBM Lab Boeblingen