Re: [PATCH v4 03/28] cpu: Introduce cpu_virtio_is_big_endian()

[Richard Henderson]

On 3/3/21 2:18 PM, Richard Henderson wrote:
> On 3/3/21 2:15 PM, Michael S. Tsirkin wrote:
> > On Wed, Mar 03, 2021 at 05:08:36PM -0500, Michael S. Tsirkin wrote:
> > > On Wed, Mar 03, 2021 at 10:46:43PM +0100, Philippe Mathieu-Daudé wrote:
> > > > Introduce the cpu_virtio_is_big_endian() generic helper to avoid
> > > > calling CPUClass internal virtio_is_big_endian() one.
> > > >
> > > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > >
> > > Using virtio in the name here probably because virtio wants this?
> > > That doesn't sound like a good naming strategy, name should
> > > tell us what function does not how it's used.
> >
> > On a more concrete proposal, how about using this change
> > to rename the virtio_is_big_endian field to guest_is_big_endian(),
> > and put the wrapper somewhere in a virtio header instead?
>
> We already one for normal guest endianness.  This one is for when virtio 
> specifically differs from that.

Hmph.  I remembered incorrectly.  I thought we had a bit of ppc weirdness in 
which endianness was reversed for virtio, but no.

I'm ok with the renaming.


r~