Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x

[Cornelia Huck]

On Wed, 25 Nov 2020 17:04:05 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> Hi Cornelia,
> 
> On 11/25/20 4:03 PM, Thomas Huth wrote:
> > On 25/11/2020 14.58, Cornelia Huck wrote:  
> >> This adds a very basic test for checking that we present devices
> >> in a way that Linux can consume: boot with both virtio-net-ccw and
> >> virtio-net-pci attached and then verify that Linux is able to see
> >> and detect these devices.  
> > 
> > Thanks for tackling it!
> >   
> >> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> >> ---
> >>
> >> A very basic test, but it would have caught the recent zPCI regression.  
> 
> Thanks for adding this test :)
> 
> >>
> >> If anyone has a better idea than using early debug shells in the Debian
> >> install image, please let me know. At least it's quick, as we can check
> >> for the devices quite early in the boot sequence.  
> 
> This is the simplest cheaper way I think.
> 
> Alternative is to use Guenter's images:
> https://github.com/groeck/linux-build-test/tree/master/rootfs/s390

I tried to use these, but it seems I would need a kernel with the
relevant drivers built-in for that, and neither Fedora nor Debian seem
to do that. Maybe I'm holding it wrong, but I think I'll just stick to
my current approach, as I have that one working :)

> 
> >>
> >> Not sure if running under both kvm and tcg on an s390 host would add
> >> useful extra coverage. Also not sure if this needs fencing on any of the
> >> public CIs (have not tried yet).  
> > 
> > We're only running the acceptance tests in the gitlab-CI, no worries about
> > the others.
> >   
> >> ---
> >>  tests/acceptance/s390_devices.py | 68 ++++++++++++++++++++++++++++++++
> >>  1 file changed, 68 insertions(+)
> >>  create mode 100644 tests/acceptance/s390_devices.py
> >>
> >> diff --git a/tests/acceptance/s390_devices.py 
> >> b/tests/acceptance/s390_devices.py
> >> new file mode 100644
> >> index 000000000000..6ce47061f35d
> >> --- /dev/null
> >> +++ b/tests/acceptance/s390_devices.py  
> > 
> > s390x_devices.py ?
> > 
> > Or maybe even machine_s390x.py instead, like the other machine*.py files?  
> 
> Feel free to use whatever name/directory structure that help others to
> find your tests (don't forget to add an entry to MAINTAINERS).

Good point, I forgot about an explicit MAINTAINERS entry.

> 
> Regards,
> 
> Phil.
>