[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Clean up includes
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] Clean up includes |
Date: |
Tue, 17 Nov 2020 11:43:56 +0000 |
On Fri, Nov 13, 2020 at 07:12:16AM +0100, Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the changes
> to the following files manually reverted:
>
> contrib/libvhost-user/libvhost-user-glib.h
> contrib/libvhost-user/libvhost-user.c
> contrib/libvhost-user/libvhost-user.h
> contrib/plugins/hotblocks.c
> contrib/plugins/hotpages.c
> contrib/plugins/howvec.c
> contrib/plugins/lockstep.c
> linux-user/mips64/cpu_loop.c
> linux-user/mips64/signal.c
> linux-user/sparc64/cpu_loop.c
> linux-user/sparc64/signal.c
> linux-user/x86_64/cpu_loop.c
> linux-user/x86_64/signal.c
> target/s390x/gen-features.c
> tests/fp/platform.h
> tests/migration/s390x/a-b-bios.c
> tests/plugin/bb.c
> tests/plugin/empty.c
> tests/plugin/insn.c
> tests/plugin/mem.c
> tests/test-rcu-simpleq.c
> tests/test-rcu-slist.c
> tests/test-rcu-tailq.c
> tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c
>
> contrib/plugins/, tests/plugin/, and tests/test-rcu-slist.c appear not
> to include osdep.h intentionally. The remaining reverts are the same
> as in commit bbfff19688d.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> No real need to get this into 5.2 at this stage. No real risk either.
>
> contrib/vhost-user-gpu/vugbm.h | 2 --
> contrib/vhost-user-gpu/vugpu.h | 1 -
> include/hw/block/swim.h | 1 -
> include/hw/display/macfb.h | 1 -
> include/qemu/nvdimm-utils.h | 1 -
> tests/qtest/fuzz/fuzz.h | 1 -
> tests/qtest/fuzz/generic_fuzz_configs.h | 1 -
> tools/virtiofsd/fuse_common.h | 2 --
> tools/virtiofsd/fuse_log.h | 1 -
> tools/virtiofsd/fuse_lowlevel.h | 3 ---
> tools/virtiofsd/fuse_misc.h | 1 -
> tools/virtiofsd/passthrough_seccomp.h | 1 -
> contrib/vhost-user-gpu/virgl.c | 1 +
> contrib/vhost-user-gpu/vugbm.c | 1 +
> contrib/vhost-user-input/main.c | 1 -
> hw/display/artist.c | 1 -
> hw/s390x/s390-pci-vfio.c | 3 ++-
> tools/virtiofsd/buffer.c | 5 -----
> tools/virtiofsd/fuse_log.c | 2 --
> tools/virtiofsd/fuse_lowlevel.c | 10 ----------
> tools/virtiofsd/fuse_opt.c | 4 ----
> tools/virtiofsd/fuse_signals.c | 5 -----
> tools/virtiofsd/fuse_virtio.c | 10 ----------
> tools/virtiofsd/helper.c | 8 --------
> tools/virtiofsd/passthrough_ll.c | 12 ------------
> tools/virtiofsd/passthrough_seccomp.c | 3 ---
> util/nvdimm-utils.c | 1 +
> 27 files changed, 5 insertions(+), 78 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [PATCH] Clean up includes, Markus Armbruster, 2020/11/13
- Re: [PATCH] Clean up includes, Paolo Bonzini, 2020/11/13
- Re: [PATCH] Clean up includes, Dr. David Alan Gilbert, 2020/11/13
- Re: [PATCH] Clean up includes, Thomas Huth, 2020/11/13
- Re: [PATCH] Clean up includes, Cornelia Huck, 2020/11/13
- Re: [PATCH] Clean up includes, Michael S. Tsirkin, 2020/11/13
- Re: [PATCH] Clean up includes,
Stefan Hajnoczi <=
- Re: [PATCH] Clean up includes, Alexander Bulekov, 2020/11/17