Re: [PATCH-for-5.2 v3 1/4] s390x: fix build for --without-default-devices

[Cornelia Huck]

On Thu, 5 Nov 2020 13:01:13 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> On Thu, 5 Nov 2020 12:58:01 +0100
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> 
> > Hi Cornelia,
> > 
> > On 11/4/20 6:25 PM, Cornelia Huck wrote:  
> > > On Wed,  4 Nov 2020 12:57:03 +0100
> > > Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> > >     
> > >> From: Cornelia Huck <cohuck@redhat.com>
> > >>
> > >> s390-pci-vfio.c calls into the vfio code, so we need it to be
> > >> built conditionally on vfio (which implies CONFIG_LINUX).
> > >>
> > >> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > >> Fixes: cd7498d07fbb ("s390x/pci: Add routine to get the vfio dma 
> > >> available count")
> > >> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > >> Message-Id: <20201103123237.718242-1-cohuck@redhat.com>
> > >> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > >> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > >> Acked-by: Greg Kurz <groug@kaod.org>
> > >> Tested-by: Greg Kurz <groug@kaod.org>
> > >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > >> ---
> > >>  include/hw/s390x/s390-pci-vfio.h | 3 ++-
> > >>  hw/s390x/meson.build             | 2 +-
> > >>  2 files changed, 3 insertions(+), 2 deletions(-)    
> > > 
> > > I think you're missing Matt's r-b?
> > > 
> > > Do you plan to send this, or should I include it on my s390-fixes
> > > branch?    
> > 
> > I plan to send a pull request with gitlab patches (or maybe
> > they will go via Alex's testing tree) but not soon. If you
> > are preparing s390-fixes patches, please go ahead taking this
> > one (I only included to have the series build succeed).  
> 
> Thanks, I plan to prepare a pull req this week, so I'll just go ahead
> and include it.

Queued to s390-fixes now (with Matt's r-b included).