[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/9] tcg: add const hints for code pointers
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 5/9] tcg: add const hints for code pointers |
|
Date: |
Mon, 19 Oct 2020 16:27:18 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 10/18/20 6:39 PM, Joelle van Dyne wrote:
> From: osy <osy86@users.noreply.github.com>
>
> We will introduce mirror mapping for JIT segment with separate RX and RW
> access. Adding 'const' hints will make it easier to identify read-only
> accesses and allow us to easier catch bugs at compile time in the future.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> include/tcg/tcg.h | 8 ++++----
> tcg/tcg.c | 4 ++--
> tcg/aarch64/tcg-target.c.inc | 19 +++++++++++--------
> tcg/arm/tcg-target.c.inc | 12 +++++++-----
> tcg/i386/tcg-target.c.inc | 10 +++++-----
> tcg/mips/tcg-target.c.inc | 33 +++++++++++++++++++--------------
> tcg/ppc/tcg-target.c.inc | 21 +++++++++++++--------
> tcg/riscv/tcg-target.c.inc | 11 ++++++-----
> tcg/s390/tcg-target.c.inc | 9 +++++----
> tcg/sparc/tcg-target.c.inc | 10 +++++-----
> tcg/tcg-ldst.c.inc | 2 +-
> tcg/tci/tcg-target.c.inc | 2 +-
> 12 files changed, 79 insertions(+), 62 deletions(-)
tcg/ppc/tcg-target.c.inc:2349:26: error: assignment discards ‘const’ qualifier
from pointer target type [-Werror]
s->code_gen_epilogue = tb_ret_addr = s->code_ptr;
How many of the targets did you build?
r~