[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 5/8] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BI
From: |
Richard Henderson |
Subject: |
Re: [PATCH v1 5/8] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC) |
Date: |
Fri, 25 Sep 2020 14:45:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/22/20 3:31 AM, David Hildenbrand wrote:
> +/* BRANCH INDIRECT ON CONDITION */
> + C(0xe347, BIC, RXY_b, MIE2,0, m2_64, 0, 0, bc, 0)
> /* BRANCH ON CONDITION */
> C(0x0700, BCR, RR_b, Z, 0, r2_nz, 0, 0, bc, 0)
> C(0x4700, BC, RX_b, Z, 0, a2, 0, 0, bc, 0)
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index b536491892..383edf7419 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -1626,6 +1626,11 @@ static DisasJumpType op_bc(DisasContext *s, DisasOps
> *o)
> return DISAS_NEXT;
> }
>
> + /* For BIC the address came from memory, we need to wrap it again. */
> + if (s->fields.op2 == 0x47) {
> + gen_addi_and_wrap_i64(s, o->in2, o->in2, 0);
> + }
I'm not keen on this sort of per-opcode checks.
I'd prefer to add an in2_m2_64w() helper that performs the load and then wraps.
r~
- Re: [PATCH v1 1/8] s390x/tcg: Implement ADD HALFWORD (AGH), (continued)
- [PATCH v1 2/8] s390x/tcg: Implement SUBTRACT HALFWORD (SGH), David Hildenbrand, 2020/09/22
- [PATCH v1 3/8] s390x/tcg: Implement MULTIPLY (MG, MGRK), David Hildenbrand, 2020/09/22
- [PATCH v1 4/8] s390x/tcg: Implement MULTIPLY HALFWORD (MGH), David Hildenbrand, 2020/09/22
- [PATCH v1 5/8] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC), David Hildenbrand, 2020/09/22
- Re: [PATCH v1 5/8] s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC),
Richard Henderson <=
- [PATCH v1 6/8] s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC), David Hildenbrand, 2020/09/22
- Re: [PATCH v1 6/8] s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC), Richard Henderson, 2020/09/22
- Re: [PATCH v1 6/8] s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC), Richard Henderson, 2020/09/25
- [PATCH v1 7/8] s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2, David Hildenbrand, 2020/09/22
- [PATCH v1 8/8] s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA), David Hildenbrand, 2020/09/22