[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 4/8] ppc/e500: Use start-powered-off CPUState property
From: |
Thiago Jung Bauermann |
Subject: |
Re: [PATCH v7 4/8] ppc/e500: Use start-powered-off CPUState property |
Date: |
Tue, 01 Sep 2020 15:39:43 -0300 |
User-agent: |
mu4e 1.4.10; emacs 27.1 |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 8/26/20 7:55 AM, Thiago Jung Bauermann wrote:
>> Instead of setting CPUState::halted to 1 in ppce500_cpu_reset_sec(), use
>> the start-powered-off property which makes cpu_common_reset() initialize it
>> to 1 in common code.
>>
>> Also change creation of CPU object from cpu_create() to object_new() and
>> qdev_realize_and_unref() because cpu_create() realizes the CPU and it's not
>> possible to set a property after the object is realized.
>>
>> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>> ---
>> hw/ppc/e500.c | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks!
--
Thiago Jung Bauermann
IBM Linux Technology Center