Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

[no-reply]

Patchew URL: 20200702115045.6171-1-thuth@redhat.com/">https://patchew.org/QEMU/20200702115045.6171-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update
Type: series
Message-id: 20200702115045.6171-1-thuth@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200702115045.6171-1-thuth@redhat.com -> 
patchew/20200702115045.6171-1-thuth@redhat.com
Switched to a new branch 'test'
0d1e389 pc-bios/s390: Update s390-ccw bios binaries with the latest changes
b853d2a pc-bios/s390-ccw: Generate and include dependency files in the Makefile
b23b6b1 pc-bios: s390x: Make u32 ptr check explicit
6b8c130 pc-bios: s390x: Use ebcdic2ascii table
e2168e6 pc-bios: s390x: Move panic() into header and add infinite loop
7a2400d pc-bios: s390x: Use PSW masks where possible and introduce 
PSW_MASK_SHORT_ADDR
267c418 pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
6bd3e6c pc-bios: s390x: Get rid of magic offsets into the lowcore
becd3ca pc-bios: s390x: Move sleep and yield to helper.h
061e9f3 pc-bios: s390x: Consolidate timing functions into time.h
7e56f4f pc-bios: s390x: cio.c cleanup and compile fix

=== OUTPUT BEGIN ===
1/11 Checking commit 7e56f4febf83 (pc-bios: s390x: cio.c cleanup and compile 
fix)
2/11 Checking commit 061e9f352a3e (pc-bios: s390x: Consolidate timing functions 
into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit becd3ca7caaf (pc-bios: s390x: Move sleep and yield to 
helper.h)
4/11 Checking commit 6bd3e6c441a1 (pc-bios: s390x: Get rid of magic offsets 
into the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: spaces required around that ':' (ctx:VxV)
#35: FILE: pc-bios/s390-ccw/cio.h:128:
+            __u16 reserved:4;
                           ^

ERROR: spaces required around that ':' (ctx:VxV)
#36: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#37: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#38: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/11 Checking commit 267c4180a374 (pc-bios: s390x: Rename PSW_MASK_ZMODE to 
PSW_MASK_64)
6/11 Checking commit 7a2400dfa22b (pc-bios: s390x: Use PSW masks where possible 
and introduce PSW_MASK_SHORT_ADDR)
7/11 Checking commit e2168e661f8d (pc-bios: s390x: Move panic() into header and 
add infinite loop)
8/11 Checking commit 6b8c130e5b38 (pc-bios: s390x: Use ebcdic2ascii table)
9/11 Checking commit b23b6b118f04 (pc-bios: s390x: Make u32 ptr check explicit)
10/11 Checking commit b853d2adc612 (pc-bios/s390-ccw: Generate and include 
dependency files in the Makefile)
11/11 Checking commit 0d1e38904c99 (pc-bios/s390: Update s390-ccw bios binaries 
with the latest changes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200702115045.6171-1-thuth@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200702115045.6171-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com