[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/30] s390x/tcg: MVC: Use is_destructive_overlap()
From: |
David Hildenbrand |
Subject: |
[PULL 06/30] s390x/tcg: MVC: Use is_destructive_overlap() |
Date: |
Mon, 23 Sep 2019 10:06:48 +0200 |
Let's use the new helper, that also detects destructive overlaps when
wrapping.
We'll make the remaining code (e.g., fast_memmove()) aware of wrapping
later.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/mem_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
index 013e8d6045..c31cf49593 100644
--- a/target/s390x/mem_helper.c
+++ b/target/s390x/mem_helper.c
@@ -330,7 +330,7 @@ static uint32_t do_helper_mvc(CPUS390XState *env, uint32_t
l, uint64_t dest,
*/
if (dest == src + 1) {
fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l, ra);
- } else if (dest < src || src + l <= dest) {
+ } else if (!is_destructive_overlap(env, dest, src, l)) {
fast_memmove(env, dest, src, l, ra);
} else {
for (i = 0; i < l; i++) {
--
2.21.0
- [PULL 00/30] s390x/tcg update, David Hildenbrand, 2019/09/23
- [PULL 01/30] s390x/tcg: Reset exception_index to -1 instead of 0, David Hildenbrand, 2019/09/23
- [PULL 02/30] s390x/tcg: MVCL: Zero out unused bits of address, David Hildenbrand, 2019/09/23
- [PULL 03/30] s390x/tcg: MVCL: Detect destructive overlaps, David Hildenbrand, 2019/09/23
- [PULL 04/30] s390x/tcg: MVCL: Process max 4k bytes at a time, David Hildenbrand, 2019/09/23
- [PULL 05/30] s390x/tcg: MVC: Increment the length once, David Hildenbrand, 2019/09/23
- [PULL 06/30] s390x/tcg: MVC: Use is_destructive_overlap(),
David Hildenbrand <=
- [PULL 07/30] s390x/tcg: MVPG: Check for specification exceptions, David Hildenbrand, 2019/09/23
- [PULL 08/30] s390x/tcg: MVPG: Properly wrap the addresses, David Hildenbrand, 2019/09/23
- [PULL 09/30] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time, David Hildenbrand, 2019/09/23
- [PULL 10/30] s390x/tcg: MVCS/MVCP: Check for special operation exceptions, David Hildenbrand, 2019/09/23
- [PULL 11/30] s390x/tcg: MVCOS: Lengths are 32 bit in 24/31-bit mode, David Hildenbrand, 2019/09/23
- [PULL 12/30] s390x/tcg: MVCS/MVCP: Properly wrap the length, David Hildenbrand, 2019/09/23
- [PULL 13/30] s390x/tcg: MVST: Check for specification exceptions, David Hildenbrand, 2019/09/23
- [PULL 14/30] s390x/tcg: MVST: Fix storing back the addresses to registers, David Hildenbrand, 2019/09/23
- [PULL 15/30] s390x/tcg: Always use MMU_USER_IDX for CONFIG_USER_ONLY, David Hildenbrand, 2019/09/23
- [PULL 16/30] s390x/tcg: Fault-safe memset, David Hildenbrand, 2019/09/23