qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH v2 09/28] s390x/tcg: MVCLU/MVCLE: P


From: Richard Henderson
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v2 09/28] s390x/tcg: MVCLU/MVCLE: Process max 4k bytes at a time
Date: Wed, 11 Sep 2019 11:05:04 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 9/6/19 3:57 AM, David Hildenbrand wrote:
> +    if (*srclen) {
> +        /* Copy the src array */
> +        len = MIN(len, *srclen);
> +        *destlen -= len;
> +        *srclen -= len;
> +        fast_memmove(env, *dest, *src, len, ra);
> +        *src = wrap_address(env, *src + len);
> +        *dest = wrap_address(env, *dest + len);
> +    } else if (wordsize == 1) {
> +        /* Pad the remaining area */
> +        *destlen -= len;
> +        fast_memset(env, *dest, pad, len, ra);
> +        *dest = wrap_address(env, *dest + len);

Again, I'm not sure fast_memmove actually handles wrap, yet.
Would it be easier to split at page boundaries rather than a
fixed 4k length?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]