[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty a
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [qemu-s390x] [PATCH] pc-bios/s390-ccw: Do not pre-initialize empty array |
|
Date: |
Wed, 28 Aug 2019 15:27:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 28.08.19 14:33, Thomas Huth wrote:
> We're clearing the BSS in start.S now, so there is no need to
> pre-initialize the loadparm_str array with zeroes anymore.
Can you add a link to the commit that does the bss clearing?
I think it was
commit 339686a358b11a231aa5b6d1424e7a1460d7f277
Author: Christian Borntraeger <address@hidden>
AuthorDate: Wed Nov 22 15:26:27 2017 +0100
Commit: Cornelia Huck <address@hidden>
CommitDate: Thu Dec 14 17:56:54 2017 +0100
pc-bios/s390-ccw: zero out bss section
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> pc-bios/s390-ccw/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c
> index a69c73349e..a21b386280 100644
> --- a/pc-bios/s390-ccw/main.c
> +++ b/pc-bios/s390-ccw/main.c
> @@ -17,7 +17,7 @@
>
> char stack[PAGE_SIZE * 8] __attribute__((__aligned__(PAGE_SIZE)));
> static SubChannelId blk_schid = { .one = 1 };
> -static char loadparm_str[LOADPARM_LEN + 1] = { 0, 0, 0, 0, 0, 0, 0, 0, 0 };
> +static char loadparm_str[LOADPARM_LEN + 1];
> QemuIplParameters qipl;
> IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));
> static bool have_iplb;
>