Re: [qemu-s390x] [Qemu-devel] [PATCH v7 37/42] cputlb: Replace size and endian operands for MemOp

[Richard Henderson]

On 8/16/19 8:38 AM, address@hidden wrote:
>  static uint64_t full_ldub_mmu(CPUArchState *env, target_ulong addr,
>                                TCGMemOpIdx oi, uintptr_t retaddr)
>  {
> -    return load_helper(env, addr, oi, retaddr, 1, false, false,
> -                       full_ldub_mmu);
> +    return load_helper(env, addr, oi, retaddr, MO_8, false, full_ldub_mmu);
...
>  void helper_ret_stb_mmu(CPUArchState *env, target_ulong addr, uint8_t val,
>                          TCGMemOpIdx oi, uintptr_t retaddr)
>  {
> -    store_helper(env, addr, val, oi, retaddr, 1, false);
> +    store_helper(env, addr, val, oi, retaddr, MO_8);
>  }

MO_UB.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~