Re: [qemu-s390x] [Qemu-devel] [PATCH v5 04/15] hw/s390x: Access MemoryRegion with MemOp

[Richard Henderson]

On 7/25/19 11:44 PM, address@hidden wrote:
> No-op SIZE_MEMOP macro allows us to later easily convert
> memory_region_dispatch_{read|write} paramter "unsigned size" into a
> size+sign+endianness encoded "MemOp op".
> 
> Being a no-op macro, this patch does not introduce any logical change.
> 
> Signed-off-by: Tony Nguyen <address@hidden>
> ---
>  hw/s390x/s390-pci-inst.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

>      for (i = 0; i < len / 8; i++) {
>          result = memory_region_dispatch_write(mr, offset + i * 8,
> -                                              ldq_p(buffer + i * 8), 8,
> +                                              ldq_p(buffer + i * 8),
> +                                              SIZE_MEMOP(8),

MO_64, eventually.


r~