[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH v2 03/10] hw/pci-bridge: Use the QOM BUS() macro

From: Marcel Apfelbaum
Subject: Re: [qemu-s390x] [PATCH v2 03/10] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus
Date: Tue, 28 May 2019 19:52:00 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 5/28/19 7:40 PM, Philippe Mathieu-Daudé wrote:
Rather than looking inside the definition of a BusState with "s->bus.qbus",
use the QOM prefered style: "BUS(&s->bus)".

This patch was generated using the following Coccinelle script:

     // Use BUS() macros to access BusState.qbus
     expression obj;
     identifier bus;

Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
  hw/pci/pci_bridge.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index c6d9ded320..8d954885c0 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -273,7 +273,7 @@ void pci_bridge_write_config(PCIDevice *d,
      newctl = pci_get_word(d->config + PCI_BRIDGE_CONTROL);
      if (~oldctl & newctl & PCI_BRIDGE_CTL_BUS_RESET) {
          /* Trigger hot reset on 0->1 transition. */
-        qbus_reset_all(&s->sec_bus.qbus);
+        qbus_reset_all(BUS(&s->sec_bus));

Reviewed-by: Marcel Apfelbaum<address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]